solid-ui icon indicating copy to clipboard operation
solid-ui copied to clipboard

Form generator relies on the outline manager - why?

Open michielbdejong opened this issue 5 years ago • 2 comments

Just came across a reference to dom.outlineManager in the form generator - I thought the outlineManager was the part of solid-panes, that manages which pane is shown, so it's unclear to me why it's necessary for the form generator to depend on that.

Digging into the code now to try to understand this more thoroughly.

michielbdejong avatar Mar 04 '20 20:03 michielbdejong

When I tried to import it as a dev-dependency, I saw this error:

~/gh/solid/solid-ui $ ./node_modules/.bin/jest test/unit/widgets/forms.test.ts 
 FAIL  test/unit/widgets/forms.test.ts
  ● Test suite failed to run

    TypeError: UI.rdf.IndexedFormula is not a constructor

      2 | import ns from '../../../src/ns'
      3 | // FIXME: https://github.com/solid/solid-ui/issues/239
    > 4 | import { getOutliner } from 'solid-panes'
        | ^

michielbdejong avatar Mar 04 '20 20:03 michielbdejong

That looks like a mishap - Forms shouldn't rely on OutlineManager AFAIK. Hope you're able to remove it.

megoth avatar Mar 05 '20 10:03 megoth