solid-ui
solid-ui copied to clipboard
Form generator relies on the outline manager - why?
Just came across a reference to dom.outlineManager in the form generator - I thought the outlineManager was the part of solid-panes, that manages which pane is shown, so it's unclear to me why it's necessary for the form generator to depend on that.
Digging into the code now to try to understand this more thoroughly.
When I tried to import it as a dev-dependency, I saw this error:
~/gh/solid/solid-ui $ ./node_modules/.bin/jest test/unit/widgets/forms.test.ts
FAIL test/unit/widgets/forms.test.ts
● Test suite failed to run
TypeError: UI.rdf.IndexedFormula is not a constructor
2 | import ns from '../../../src/ns'
3 | // FIXME: https://github.com/solid/solid-ui/issues/239
> 4 | import { getOutliner } from 'solid-panes'
| ^
That looks like a mishap - Forms shouldn't rely on OutlineManager AFAIK. Hope you're able to remove it.