solid-ui icon indicating copy to clipboard operation
solid-ui copied to clipboard

Find out intended behaviour to shortNameForFolder

Open michielbdejong opened this issue 5 years ago • 5 comments

shortNameForFolder returns 'example.com' for 'https://example.com/' and '/' for 'https://'. I'm not certain this is actually by design, it might be that the intended behaviour was that the domain root would already get labeled '/'. That would make more sense to me for a filebrowser.

michielbdejong avatar Feb 13 '20 08:02 michielbdejong

See https://github.com/solid/solid-ui/blob/master/test/unit/acl/acl-control.test.ts#L44-L65 (edited) for the current behaviour.

michielbdejong avatar Feb 13 '20 08:02 michielbdejong

I'm thinking things may have gotten moved around, the link above gives a 404 error.

SharonStrats avatar Feb 23 '20 23:02 SharonStrats

Edited the link, thanks.

michielbdejong avatar Feb 24 '20 08:02 michielbdejong

You might want to double check this with @timbl if you're still uncertain about the intended behavior.

megoth avatar Feb 24 '20 10:02 megoth

@timbl do you know?

michielbdejong avatar Feb 24 '20 12:02 michielbdejong