Michał Dudak comments

Repositories
Issues
Comments

Results 495 comments of


                                            Michał Dudak

[core] Improve DX of importing Base UI components

Yes, the resulting bundle does not contain the code of unused parts.

[NoSSR] Port the component from legacy Base UI

Component removed in #3398

[Dialog] Configure initial focus

@vladmoroz I'll address the bug in a separate PR. An empty string is a valid value of PointerEvent's pointerType field, so I included it here as well. As for naming,...

[Dialog] Configure initial focus

An empty string is an unknown pointer type (see https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerType#value). It's not really the type of the event (as this is PointerEvent or MouseEvent), but the user's input device that...

[Dialog] Configure initial focus

> Do we return an empty string in this case or do we pass through the original type? We pass through whatever there is originally.