Michał Dudak

Results 463 comments of Michał Dudak

Literal unions such as AccordionRoot's `orientation` should be expandable like function definitions

I checked it manually and it turns out that this PR (with the lastest master merged in) produces a larger package than what's on master. I ran `pnpm build and...

Since the bundle size checker is running, we can continue with this. The size saving aren't enormous (-0.80% gzipped for the whole library), but they might get slightly more significant...

> in case you were holding back atm 🙂 No, that's fine :) There are size savings already, so we can move forward with this. I'd like to merge #2049...

> However, there's a tradeoff here. When opening the Select for the first time, it's noticeably slow compared to before, since the work was already done on load when the...

Can we then see how much the current implementation can be sped up and then decide on deferring mounting strategy? We also considered using an idle callback (or timeout) to...

I like the ESLint rule the most. It's hard to think of cases where we'd want an optional prop not to accept explitcit `undefined`, so there should be no cases...

I'd disable the following rules: - `declaration-empty-line-before`, `custom-property-empty-line-before` - makes long rulesets more readable - `import-notation` - the bundler understands the simple notation we use And autofix all the remaining...

The Base UI slider has `onValueChange` and `onValueCommitted`. While they're not the same as proposed props, it seems to me that they serve the same purpose.

No, it seems it somehow was fixed in the meantime. Lighthouse doesn't report layout shift problems anymore on master. There still is a layout shift when using transitions, but it's...