Michael Kirk
Michael Kirk
I should mention that there are still a lot of valid geojson documents that this will fail to parse, or parse incorrectly. Specifically, we assume that the first square bracket...
bors r=frewsxcv
Added a follow up issue for more robustness fixes we could do here: https://github.com/georust/geojson/issues/207
Thinking about it a bit more... though using generics is a neat trick that allows us to only add one method to `impl Feature`, I always find generics really hard...
Another awkward thing I just realized: While this works: ``` let collection = geojson::FeatureCollection::try_from(geojson)?; for mut feature in collection.features.into_iter() { // [1] getting a property off each feature let population...
Thanks for weighing in! > Feature::property_as::("key") Right, this looks nice, but there are a couple of complications that I'm hung up on which aren't clear from your example: Given: ```...
> “Discoverability” of a API is important. Could that be addressed with lots of doc comments showing all the options? Examples would definitely help, but I'm less worried about discoverability...
This is a fun case study in API design! For context: Originally, the zonebuilder geojson output code looked like this: https://github.com/zonebuilders/zonebuilder-rust/commit/0ec72093eb21e9b6f74a0c3a162a8a186511fc32 # 1 ``` let mut features: Vec = polygons...
FWIW, I like @rmanoka's proposal.
> To summarize, this is the impl. checklist I'm suggesting: That sounds great, thanks for laying it out @rmanoka!