Michael Kirk
Michael Kirk
:+1: To make sure I'm understanding, and to clarify why I think this is important: The previous behavior allowed me as a crate author to pre-build bindings and include them...
I wonder if the ultimate solution is to try to get c_size_t added to [std::os::raw](https://doc.rust-lang.org/std/os/raw/index.html) 😬
> The problem here is that the absence/presence of the geos based method does not depend only on rust code base but on how gdal is computed on the platform....
> @michaelkirk More I think about this, more I do not see very much difference between a function not available because gdal is not of the required version and function...
> Do you know if it possible to detect in the build.rs script at compile time if the feature 'with_geos' is activated by the user ? I'd probably do something...
I'm late to the discussion, so I'm sorry if I missed something, but another approach could be: Rather than trying to work-around the fact that we can't build on docs.rs...
> Yes, we use an indirection from having a sys crate. I didn't realise the crates build env already includes libgdal which seems needed for the pkg-config in gdal-sys/build.rs I...
As a reference, the [georust/proj](https://github.com/georust/proj) crate does two things to document feature specific methods: 1. enables features for the docs build ([src](https://github.com/georust/proj/blob/801f6537b63dcaf8b5f25eba4ea9715e98190b09/Cargo.toml#L36)): ``` [package.metadata.docs.rs] features = [ "proj-sys/nobuild", "network", "geo-types"...
>> Why did we lose the clippy check? >> > i brought back the clippy check in the latest commit, if you wanna see the errors that get returned. maybe...
I'm having a go at this here: https://github.com/michaelkirk/magick-rust/pull/1/files Which relies on the WIP sys crate here: https://github.com/michaelkirk/imagemagick-sys You can see a successful build (only on macos at the moment) here:...