Michael Kirk

Results 550 comments of Michael Kirk

> the dependencies and build.rs for magick-rust would be modified to use your new crate? Yes, that was my thought. You can see the modifications so far here: https://github.com/michaelkirk/magick-rust/pull/1 >...

Thinking about this a bit more - it seems like a common use case would be to build a feature by adding properties to a geo-types geometry. I think a...

You're right to bring it up - it feels redundant and verbose. My thinking was that there was value in having different names for methods across traits: ``` ToGeoJsonFeature::geojson_feature(&self) ToGeoJsonGeometry::geojson_feature_with_props(&self,...

I've taken a different approach to the ergonomics problem in #199, based on serde. I'm curious for any feedback! (/cc @themmes)

> want to build up a use `serde::ser::SerializeMap` I'm not very familiar with serde. It seems like this would also be a bunch of allocation? I was hoping for some...

By default, it looks like serde_json wants to use f64. https://github.com/serde-rs/json/blob/fd6741f4b0b3fc90a58a6f578e33a9adc6403f3f/src/number.rs#L31 There is an arbitrary_precision feature we might be able to use, but there may be a perf cost.

Hi @Robinlovelace - just to make sure that I'm understanding, my read of the documentation you've linked to and [GEOS's own documentation](http://geos.refractions.net/ro/doxygen_docs/html/classgeos_1_1geom_1_1PrecisionModel.html) say that, ultimately in those libraries, all math...

> I think, my first review comment is still relevant. Forcing the output of any FeatureCollection to a GeometryCollection seems not right to me. What output are you expecting when...