Michael Kirk

Results 550 comments of Michael Kirk

Awesome! Just in case you weren't already aware, our existing CI runs are configured at: https://github.com/georust/proj/blob/main/.github/workflows/test.yml I'm imaging we can add one or more entries for windows there, like we...

I'm sorry but I don't understand your question. Can you try to rephrase it or give a more specific example? The docs for Indeterminate if you haven't seen them: https://docs.rs/geo/latest/geo/enum.Closest.html#variant.Indeterminate

My fix might not be right, but it's definitely closer than what was there before. Because there was overlap in the zip code prefixes (both az and eastern were assigned...

@stonylohr - please feel free to work on which tasks you prefer. I'm of course most interested in the correctness issues. As long as it's under a couple hundred lines,...

One approach: - Store some test inputs along with their respective Karney-approved outputs in an external file. - Have a test harness method that checks all these inputs See https://github.com/georust/geographiclib-rs/blob/master/src/geodesic.rs#L2645...

Thank you for laying out an approach. It sounds basically good, but I'd prefer to simplify it a bit: > we might not want to just store a large test...

BTW the documentation at https://zenodo.org/record/32470 does look like a reasonable foundation - good find! I'm not sure if there are other edge cases that we'd want to emphasize in the...

> generate a test_fixtures/test_data_unzipped/GnomTest-short.dat with 10k test cases and test_fixtures/test_data_unzipped/GnomTest.dat with 500k test cases, but don't check it in. Zip and upload it somewhere. These exact numbers (10k vs. 500k)...