Michael Kirk

Results 550 comments of Michael Kirk

> That's a good question - would this be a legal WKT and/or do we want to support such cases? Whoops, that example I gave was invalid WKT. I forgot...

I guess my point is that it really seems like `POINT EMPTY` is a special beast in that it can't be expressed as a geo-type today. Any work-around might benefit...

You might also be interested in https://github.com/georust/geozero Which allows things like: ``` geojson.to_wkt() ```

I'm still kind of getting the hang of GeoZero myself, but I think the idea is that you can implement: `impl GeozeroGeometry for YOURTYPE` or `impl GeozeroDatasource for YOURTYPE` and...

Along with that, we should include some examples of the serde integration once #59 is merged.

> we'd alias Coordinate to mint::Point, or something along those lines. and then we can convert types between crates at no cost This is true for any integration using geo-types...

My impression is that `robust`, being a pretty low level "building block" for other crates, means its use cases are relatively wide. I'd prefer to keep it no_std even if...

> I infer it's OK to make changes that might not work on ES version 6 or lower, but let me know if that's incorrect and I can try again....

> I just updated the ["official"](https://github.com/pelias/documentation/blob/master/requirements.md) place where we document Elasticsearch version support so it no longer includes Elasticsearch 6. In practice, we haven't taken steps to preserve Elasticsearch 6...

I've rebased this - it's still a draft though because it depends on the new config format in https://github.com/pelias/config/pull/141