Michael Kirk

Results 550 comments of Michael Kirk

I don't use either of those traits, but taking a quick look at the code, your interpretation seems correct to me @JosiahParry. Looking at the git archeology, it seems probable...

I don't think we should change PartialEq to be approximate, because I think this would surprise lots of people. Instead, have you seen our usage of approx? There's probably some...

Yeah, floating point makes comparisons annoying. It's not so much conceptually difficult, but it makes writing test code very verbose which is a pain. But people assume a contract with...

Reconciling different geometry representations is hard, and IMO it's probably not possible to match all users expectations 100% of the time. It definitely feels like a "pick your tradeoffs" kind...

It's not exactly as you described, but do you think something like https://postgis.net/docs/ST_Split.html would serve your purposes? (it doesn't yet exist in georust)

> Hi @urschrei, @michaelkirk, it seems like every time I push changes to my fork it is triggering all the checks on this draft PR. Should I be concerned about...

I'm just looking into this a bit before giving in on #920. It is interesting that the distance calculation changes depending on the winding of the input polygons. I noticed...

I'm not able to reproduce this crash - I tried in #922. Can you share any more details about your issue? Preferably in the form of code and the log...

Ok, I've updated the description with the appropriate details. It seems like a pretty straight forward overflow issue. Can you use i64 geometries instead of i32? Also, the geometry you...

Note there seems to be some code intended to cover the case of "resizing the browser shouldn't unlock the viewport", but from what I can tell it is not functioning...