Michael Bromley

Results 750 comments of Michael Bromley

I just had a play around and discovered something interesting: The `pagination-template` directive also uses an attribute selector, so you can add it directly onto the `` component: ```html prev...

Yes, I think it's worth adding. It could go as a note with a small code example at the end of the [directive section](https://github.com/michaelbromley/ngx-pagination#paginationcontrolsdirective)

Hi, Are you suggesting this for the `PaginationControlsComponent`? Because you could already implement your own version of this by using a custom template.

This issue is not well formatted and I don't know what I should be looking at. Please edit down to the bare minimum code which reproduces your error. Thanks.

I am not familiar with Ionic or how it interacts with Angular, but by putting a few console.log calls in your demo, it seems that the `ngOnDestroy` method of `InstructionsComponent`...

Hi, Currently there is no support for this, you would indeed need to create a custom template.

Hi, yes, a PR would be welcome!

Hi! Thanks for this PR - I can see a lot of careful work went into it 👍 A couple of questions: 1. You added the OrderLine custom fields to...

I found that if you set `eager: true` in your custom field config, it will indeed be joined in the OrderItemPriceCalculationStrategy. I'm therefore tending to think that we should not...

Would you like to add a commit which reverts the eager loading part? Then I can merge this PR :)