Michael Bromley comments

Results 750 comments of


                                            Michael Bromley

Can i change the pagination-control numbers(1 2 3) to other values like 'Anything1 Anything2 ...' using ngFor* on array?

You've got to fill out the issue template and include more info, please

a11y: using span for button with disabled class breaks contrast check

Hi, Thanks for the report. > Elements with disabled attribute is skipped by the tool Does that mean we can just additionally add a `disabled` attribute to the `` and...

PaginationService emits twice?

Hi, Just looked into this and yes this is the case. The thing is, `PaginationService` is not part of the public API of this library so I would not necessarily...

PaginationService emits twice?

> I looked more into the code and i found the PaginationPipe emits the id when it's registered (the clone) and also when I set the currentPage with the Service....

pagination control "next" is visble after page gets loaded even if there is no data present in tha table.

Hi, can you make a StackBlitz reproduction please? https://stackblitz.com/edit/angular-e1f9hq

pagination control "next" is visble after page gets loaded even if there is no data present in tha table.

I don't mean you need to reveal proprietary code, just a minimal reproduction that demonstrates the issue. Otherwise I would have to create the reproduction myself in order to ascertain...

Feat: Angular 13 Update | Enable Ivy

Yes, this would be good to do. I'm rather limited for time at the moment, but I would happily accept any help on this if anyone wants to offer. Otherwise...

Issue with itemsPerPage

Hello, I think this is happening because you are passing in the `totalItems` option, which tells the PaginatePipe that you are doing [server-side paging](https://github.com/michaelbromley/ngx-pagination/blob/737cc1611ae3ceb7150e6aad5efed67b10ba0a54/src/paginate.pipe.ts#L46). The pipe will then assume the...

NullInjectorError: No provider for PaginationService!

Hi, Please provide at least some code of your NgModule where you are using this library.

PaginationControlsComponent does not export paginationApi

Hi! Sure, that sounds like a reasonable feature to add. A PR is welcome!