Michael Bromley

First feedback from testing: - We need a way to handle errors that might arise in the side-effects. For example, I set up a free gift side-effect similar to the...

Hi Julien! Thanks for the contribution. Can you give a bit of detail about your use-case on why you want to use tags in the shop api? I'd like to...

Hi @julien-monchany, yes thanks. I've been unusually busy these part weeks so didn't get a chance to triage all the open issues. So I'm going to leave this under consideration...

Pasting from Slack conversation to make it public: --- Thanks for taking the time to try to solve this. In general, running on port 4200 doesn't work due to the...

Note, error seems to come from this part: https://github.com/vendure-ecommerce/vendure/blob/3835f8b22cb5b61f22c372a4f251907bc8f07a09/packages/job-queue-plugin/src/bullmq/bullmq-job-queue-strategy.ts#L86-L97 in the case of worker instances configured to only handle a subset of jobs, the situation of having no defined `processFn`...

Adding some comments from Slack: --- Izayda: What actions should be triggered in search plugin? Full reindex? Michael: Interesting question. With Facets, I think we need to consider what happens...

OK so how about we handle the above case like this: - On removing a Facet from a Channel - we check to see if any Products or ProductVariants in...

Just adding a Facet to a channel should not need to change the search index (should it?). But adding a Collection will require not a full reindex but a running...

Merged in https://github.com/vendure-ecommerce/vendure/commit/34840c943d5d57d1e652352d89196ceb5dc666f8 Thanks for your help on this! 🙏

Is it not possible to get the httpAdapter post-bootstrap and call the middleware there? ```ts const app = await bootstrap(config); app.use(Sentry.Handlers.requestHandler()); // or (i think this might be doing the...