Michael Bromley

Results 750 comments of Michael Bromley

Is it just the nav menu that is missing? Are the collections showing on the landing page below the big hero image?

Yeah that's a good point. So there are 2 approaches we can take: 1. Do not transition the order to `ArrangingPayment` until the very last moment, immediately before we make...

@kyunal yes you are totally correct in your assessment - an action taken on adding would be better. Or - maybe even better: When executing `addItemToOrder`, if we get a...

Hi! Thanks for the report. That line of code is making a _lot_ of assumptions about the shape of the error object! We need to have something a bit more...

ah good find! I also ran into this and due to lack of time I just had to hard-code. So from reading that linked doc, it looks like we'd need...

Hi @biesbjerg, I've been sponsoring you (via the @vendure-ecommerce org) for your great work on this library since Sept 2021. I just ran into this issue and I'm concerned about...

I just checked into this, and it appears that the behaviour described above is due to this line: https://github.com/vendure-ecommerce/vendure/blob/b45464eb1fa01a8c6f1480600c2b20a56700d6f2/packages/admin-ui/src/lib/order/src/components/order-table/order-table.component.ts#L54 In short, the Admin UI is skipping any custom fields where...

Thanks @skid & everyone for the feedback. > Everything that runs out-of-order wrt the request, should be, abstracted away in a task queue. If not possible - it should be...

This has come up before but there are 2 major challenges: 1. The idea of waiting on async work is IMO not really in line with the observer pattern, which...

Would anyone like to build a poc PR which does this better? Is it possible to do in a non-breaking way?