Michael Osipov comments

Results 569 comments of


                                            Michael Osipov

[MNG-5600] Dependency management import should support exclusions

@cstamas @gnodet @hboutemy Is this something we can consider for 4? I don't think it would be appropriate for 3.9.0, but it is opt-in only. WDYT?

[MNG-7310] Using the plexusContainer to prevent loading lifecycle defined by extensions from other submodules.

@MartinKanters Should I test again after your followups?

[3.9.x] [MNG-7401] [MNG-7474] Keep a single maven session and fix session scope

We have TLS-based solutions in past releases and we had to revert. What makes this one different?

[3.9.x] [MNG-7401] [MNG-7474] Keep a single maven session and fix session scope

Is there a reasonable IT for this?

[3.9.x] [MNG-7401] [MNG-7474] Keep a single maven session and fix session scope

> I can write one for [MNG-7474](https://issues.apache.org/jira/browse/MNG-7474). [MNG-7401](https://issues.apache.org/jira/browse/MNG-7401) is an internal behavior and would require a junit test rather than an IT imho. I guess so that would be best

MNG-3525-maven-settings - settings.xml allowing mirror definitions inside profiles

@jvanzyl Without looking deeply into this, it looks like a massive commit with a model change. This should be in 3.4 or later. @nitram509 You have refomatted some code to...

[MNG-7375] prevent potential NPE in Metadata.merge(...)

This PR hides the fact that the input data is invalid. Obviously, we need a `MetadataValidator`.

[MNG-7375] prevent potential NPE in Metadata.merge(...)

I see two issues: * Modello generates a broken model therefore you assume the prefix to be optional. * The complete absence of a `MetadataValidator`. Would have expected that we...

[MNG-7375] prevent potential NPE in Metadata.merge(...)

@rfscholte

[MNG-7375] prevent potential NPE in Metadata.merge(...)

> Both issues are correct but are rather follow-ups to [MNG-7375](https://issues.apache.org/jira/browse/MNG-7375). My question is about how to deal with a missing prefix within `Metadata.merge` (this can happen even if the...