maven icon indicating copy to clipboard operation
maven copied to clipboard

[MNG-7310] Using the plexusContainer to prevent loading lifecycle defined by extensions from other submodules.

Open MartinKanters opened this issue 3 years ago • 3 comments

Related issue: https://issues.apache.org/jira/browse/MNG-7310 Related PR for integration tests (WIP): https://github.com/apache/maven-integration-testing/pull/131


Following this checklist to help us incorporate your contribution quickly and easily:

  • [x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles, where you replace MNG-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

MartinKanters avatar Dec 23 '21 13:12 MartinKanters

RU sure you don't need to perform lookup on each call (instead to keep the map in final member?) This is a singleton, so the map you lookup in constructor, once inited, would not change....

cstamas avatar Jan 06 '22 12:01 cstamas

RU sure you don't need to perform lookup on each call (instead to keep the map in final member?) This is a singleton, so the map you lookup in constructor, once inited, would not change....

Ah, then it is indeed best to lookup the map once and store it in an member variable. Good suggestion!

MartinKanters avatar Jan 08 '22 15:01 MartinKanters

Ah, then it is indeed best to lookup the map once and store it in an member variable. Good suggestion!

Just realized you meant exactly the opposite. Anyway, changed it accordingly.

MartinKanters avatar Feb 11 '22 15:02 MartinKanters

@MartinKanters Should I test again after your followups?

michael-o avatar Sep 16 '22 11:09 michael-o

@MartinKanters Should I test again after your followups?

I took care of that :)

MartinKanters avatar Sep 16 '22 12:09 MartinKanters