MNG-3525-maven-settings - settings.xml allowing mirror definitions inside profiles

[nitram509]

This improves user settings to have a mirrors list switched on/off via Maven profile. See commit messages for details.

Direct issue link: https://issues.apache.org/jira/browse/MNG-3525

Any feedback is welcome.

[jvanzyl]

Looking through the changes, definitely useful. Just a suggestion for your for your Git commit messages: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

[nitram509]

Thank you for this fast feedback.

[nitram509]

I've just rebased the latest commits from master.

[nitram509]

Is there anything I miss, that this PR can be merged? Or is there a plan/roadmap when merge could happen?

[jvanzyl]

I suggested the link on how to make comments so you would adjust them. Nothing is easy to read with the way they currently are. For example, I'm not sure why you introduced the CommandLineSettings and didn't use the existing classes.

[jvanzyl]

If you're around tomorrow I can spare an hour if you want to work together in a hangout to try and get this merged. It's a good feature, I just have some questions and we might need a small refactor.

[nitram509]

Sure. Btw.my timezone is UTC+1 ;)

[michael-o]

@jvanzyl Without looking deeply into this, it looks like a massive commit with a model change. This should be in 3.4 or later.

@nitram509 You have refomatted some code to Maven guidelines which I appreciate but they are unrelated to this PR. Please create a separete PR for these kinds of improvements. PS: UTC+1 isn't a timezone, it's an offset. Europe/Berlin is ;-)

[jvanzyl]

@michael-o the model change will be all right provided the reader ignores fields it doesn't understand. So newer versions that understand the change can deal with it accordingly. Older versions will just ignore them. If this is not the case then I agree. I have no intention of breaking users with the change but not very concerned which version it goes into. We don't really follow anything reasonable yet insofar as how we change our versions with respect to features or apis or both together. I really only care that it doesn't surprise users.

[jvanzyl]

@nitram509 while i'm in California meeting up is a bit tough, but I will be back in Toronto tomorrow and then I'll email you and we'll figure out a time.

[nitram509]

@jvanzyl For me it's to late now, let's talk tomorrow.