Maximilian Hils comments

Results 653 comments of


                                            Maximilian Hils

Support default values specified in Pydantic Models

I think pydantic is mainstream enough that it's worth to support this - contributions welcome!

Type annotation parsing warning for Pydantic BaseModel private attributes

I think pydantic is mainstream enough that it's worth to support this - contributions welcome!

Import resolution for init.pyi stub picks wrong package

Thanks! This probably needs some extra work here: https://github.com/mitmproxy/pdoc/blob/da0c1cdd0f94146570cbb27a2ed7bc01bb77d1f8/pdoc/doc_pyi.py#L49-L52 to make the import machinery work.

Embedded local images not working when inside init

We have file embedding working in CI, so this is surprising. Can you provide a repository with a minimal repro please?

Embedded local images not working when inside init

Thanks for the reproducer. Your repro has a bunch of file inclusions, but I assume we are talking about the following snippet: https://github.com/HackXIt/minimal-example-pdoc-embedded-image/blob/6670ac75258b6aecc233ec861a42d3dec389a5b0/src/__init__.py#L3-L7 The problem here is that pdoc just...

Embedded local images not working when inside init

If you want to include external files, the best way is really https://pdoc.dev/docs/pdoc.html#include-markdown-files. Or you write your docstrings so that relative paths match for pdoc.

Customize level of headings that are wrapped in anchor links?

I don't think it's in the docs, but happy to merge a PR that adds it to the "header-ids" bullet in https://pdoc.dev/docs/pdoc.html#markdown-support! :)

Customize level of headings that are wrapped in anchor links?

I don't know, this should be in the markdown2 docs. :) On Fri, 9 Aug 2024, 16:17 Leon, ***@***.***> wrote: > happy to merge a PR > > Can do,...

Add support for Python 3.13

The only remaining issue here is https://github.com/python/cpython/issues/122981.

pdoc incorrectly orders references with numpy formatting

Thank you for the report! This very likely is a bug in [markdown2](https://github.com/trentm/python-markdown2), the Markdown library we use in pdoc. :)