Maximilian Hils comments

Results 653 comments of


                                            Maximilian Hils

Use Thug YARA URLclassifiers

Hi Mikael, thanks for the input. I think that's something quite useful for the specific use case. With the mitmproxy merge, I'm not sure whether this is something we want...

Rework Quickstart window.

references https://github.com/mhils/HoneyProxy/issues/53

AppArmor: support path globs when merging profiles

Looks like CI failure are unrelated to the PR and need a restart. :)

add pre-commit support

I'm not too familiar with precommit, but happy to take a look at a PR! :)

Error parsing annotation: 'type' object is not subscriptable

Where did you learn about this `tk.Event[tk.Text]` syntax? This is not a pdoc bug, this is an issue with tkinter or with the annotation: If you open a Python shell...

Error parsing annotation: 'type' object is not subscriptable

This is nothing we can fix in pdoc unfortunately, the tkinter folks need to make sure that their type annotations do not raise if evaluated.

Error importing module: no signature found for builtin type `<class 'type I wrote'>`

Thanks for tracking this down! We clearly shouldn't raise on this.

Add options for include directive

Thanks! This looks super nice now. Could you please add some basic tests for `_rst_extract_options` and `_rst_include_trim` in [test_docstrings.py](https://github.com/mitmproxy/pdoc/blob/main/test/test_docstrings.py)? Otherwise this looks good to go.

Add options for include directive

No worries and thanks again! :) On Thu, May 16, 2024 at 9:05 PM Frank Harkins ***@***.***> wrote: > @mhils thanks for finishing this up! Sorry I > didn't get...

Proposal: Document each member at the lowest-level submodule, with higher level modules pointing at submodule's primary declaration without duplicating them.

This doesn't sound completely unreasonable, but also more complexity than I would like to adopt. You can maybe do something like this: ```python from . import engine Engine = engine.Engine...