pdoc icon indicating copy to clipboard operation
pdoc copied to clipboard

Published 20 hours ago • verified publisher icon mitmproxy

Add options for include directive

Open frankharkins opened this issue 10 months ago • 1 comments

Adds support for the start-* and end-* options of the rst include directive. Closes #682.

frankharkins avatar Apr 20 '24 09:04 frankharkins

Thanks! This looks super nice now. Could you please add some basic tests for _rst_extract_options and _rst_include_trim in test_docstrings.py? Otherwise this looks good to go.

mhils avatar May 02 '24 08:05 mhils

@mhils done, let me know if it's ok

frankharkins avatar May 12 '24 20:05 frankharkins

@mhils thanks for finishing this up! Sorry I didn't get round to it earlier

frankharkins avatar May 16 '24 19:05 frankharkins

No worries and thanks again! :)

On Thu, May 16, 2024 at 9:05 PM Frank Harkins @.***> wrote:

@mhils https://github.com/mhils thanks for finishing this up! Sorry I didn't get round to it earlier

— Reply to this email directly, view it on GitHub https://github.com/mitmproxy/pdoc/pull/684#issuecomment-2115992390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHY2PXQFSDW54C3J3I4GWTZCT7NTAVCNFSM6AAAAABGQLOUWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHE4TEMZZGA . You are receiving this because you were mentioned.Message ID: @.***>

mhils avatar May 16 '24 19:05 mhils