Maximilian Hils

Results 426 comments of Maximilian Hils

Having @roniemartinez as the maintainer of pybrowser is a big plus, but I do not like the idea of adopting three new dependencies for this though (pywin32 and pyxdg are...

I don't want to add pywin32 as a dependency if they don't ship abi3 wheels, so that's a hard no for me.

I didn't observe this yet. Can you share a core dump?

Thanks @dur-randir! /cc @decathorpe - any idea what could be going on here?

@Memexurer: Your issue seems completely unrelated.

@gcmurphy: you're seeing this on exit only as well?

> However, I don't know if this has any other side-effects like not being able to specify all cipher suites at this time, otherwise I already would've created a PR....

Thanks @ich199! The change generally makes sense to me. Would you mind adding a `X509V3_EXT_ERROR_UNKNOWN` binding to cryptography and then use this here instead of defining a custom constant?

Awesome, thanks! Bumping the cryptography requirement here is perfectly fine (and preferred), cryptography and pyOpenSSL releases go more or less in tandem. :)

See https://github.com/pyca/pyopenssl/pull/1242 for more context.