pyopenssl icon indicating copy to clipboard operation
pyopenssl copied to clipboard

fix X509Extension __str__() method for unknow extension types

Open ich199 opened this issue 1 year ago • 5 comments

fixes: https://github.com/pyca/pyopenssl/issues/1238 fixes: https://github.com/pyca/pyopenssl/issues/270

Unsure if it would be preferred to use 65536 instead of 1 << 16 when defining X509V3_EXT_ERROR_UNKNOWN, but I copied the syntax used in OpenSSL

ich199 avatar Aug 10 '23 14:08 ich199

tests seem to be failing due to https://github.com/pyca/pyopenssl/issues/1240

ich199 avatar Aug 10 '23 16:08 ich199

tests are now failing due to an issue in a new release of sphinx (7.2.5) https://github.com/sphinx-doc/sphinx/issues/11662

ich199 avatar Sep 01 '23 13:09 ich199

Thanks @ich199! The change generally makes sense to me. Would you mind adding a X509V3_EXT_ERROR_UNKNOWN binding to cryptography and then use this here instead of defining a custom constant?

mhils avatar Sep 05 '23 12:09 mhils

Thanks @mhils, I've created the binding in cryptography as requested and that's been merged. I'm guessing it would be preferred to backport that to 41.0.x rather than bumping the cryptography requirement here?

ich199 avatar Sep 07 '23 08:09 ich199

Awesome, thanks! Bumping the cryptography requirement here is perfectly fine (and preferred), cryptography and pyOpenSSL releases go more or less in tandem. :)

mhils avatar Sep 08 '23 12:09 mhils