pyopenssl
pyopenssl copied to clipboard
fix X509Extension __str__() method for unknow extension types
fixes: https://github.com/pyca/pyopenssl/issues/1238 fixes: https://github.com/pyca/pyopenssl/issues/270
Unsure if it would be preferred to use 65536
instead of 1 << 16
when defining X509V3_EXT_ERROR_UNKNOWN
, but I copied the syntax used in OpenSSL
tests seem to be failing due to https://github.com/pyca/pyopenssl/issues/1240
tests are now failing due to an issue in a new release of sphinx (7.2.5) https://github.com/sphinx-doc/sphinx/issues/11662
Thanks @ich199! The change generally makes sense to me. Would you mind adding a X509V3_EXT_ERROR_UNKNOWN
binding to cryptography and then use this here instead of defining a custom constant?
Thanks @mhils, I've created the binding in cryptography as requested and that's been merged. I'm guessing it would be preferred to backport that to 41.0.x
rather than bumping the cryptography requirement here?
Awesome, thanks! Bumping the cryptography requirement here is perfectly fine (and preferred), cryptography and pyOpenSSL releases go more or less in tandem. :)