Michael Dawson

Results 1203 comments of Michael Dawson

This is where we think adding would make sense - https://nodejs.org/dist/latest-v18.x/docs/api/n-api.html

Nick will: 1. create new page in abi-stable-node repo which lists the bindings 2. PR in a link to that page in the Node.js core API documentation

This would be really useful, great suggestion!

I'll defer to @Trott on this one since he probably looks at the coverage output on a more regular basis. If he's comfortable then I'd be ok as well. Having...

Yes, I looked at one ok, but then when I selected another I got the error I showed. After that I could not find one that would display.

I still get this from 2 different machines. I even tried using firefox and still get the same thing: https://codecov.io/gh/nodejs/node/src/master/lib/_http_incoming.js ![image](https://user-images.githubusercontent.com/9373002/102795059-40f80800-437a-11eb-9f82-a24fd1872de0.png)

@thomasrockhu FYI, seems to be an ongoing issue, not sure why its affects some but not all.

@slimcoders that is one of the reasons we generate/publish the coverage info. Many PRs to increase coverage have come from that so it is a good way to contribute :)

I'd really like us to switch over as well if it provides the information needed. @Trott do you look at it/use it regularly? Every time we discuss I do a...

I'm not signed in to codecov. To sign in it seems to want a bunch of organization access.