Mark Hammond

Results 678 comments of Mark Hammond

It should be possible for objects - https://mozilla.github.io/uniffi-rs/udl/interfaces.html#exposing-methods-from-standard-rust-traits. It's not possible for records because records have no methods (and it's not immediately obvious we should fix that, given every method...

See also https://github.com/mozilla/uniffi-rs/tree/main/fixtures/trait-methods

I can see how records might do this for eq. Display needs a Rust impl IIUC. For Debug, the subset of supported types is such that maybe we could think...

Thanks. Any chance you could split this into one with no functional changes and one where the behavior is changed? Some of the COM ones I'd need to dig deeper...

Thanks - but I was hoping the changes without functional effect were uploaded as I'd land them - eg, the freeing of a variable isn't controversial so I'd be fine...

Let me preface this by saying I'm not a fan of UDL for all the reasons you specify. I constantly fail to get the order of arg names and types...

The one scenario where proc-macros alone don't work is whenever "library mode" doesn't work - ie, wherever we can't get hold of the metadata emitted by proc-macros. It's not clear...

> and making it not work without notice seems quite weird, so I think it wasn't intended...:? Well, Java was never actually intended to work in the first place :)...

> The other option would simply be including in option in the uniffi config file which excludes the java.lang.ref code completely I think we'd be fine with a patch which...

> I couldn't find any tests which check the whole generation logic end-to-end. If I need coverage, could someone help me out here? Sadly we do not have a story...