Mark Hammond

Results 678 comments of Mark Hammond

I don't think that someone seeking out the pywin32 installer is well served by splitting it into multiple packages to download and run. Conversely, I don't think people looking for...

> Given we make assumptions about a Handle maybe the from_raw should already be unsafe and have additional documentation. Yeah, I agree that this seems more about `from_raw` then the...

> otherwise we'd need to treat many more things as unsafe too? Not sure what I was thinking really - all use of handles is ultimately unsafe and all callers...

There are some places we use `core::` where using `::core::` would probably solve this - eg, [here](https://github.com/mozilla/uniffi-rs/blob/e83fc4eae267b772e69f7eab720d088a7b47fcea/uniffi_meta/src/types.rs#L149)

I think this is a dupe of #1137, even though that issue mentions UDL.

Turns out this is Kotlin specific, Python and Swift are fine with it.

No plans, we'd love a PR from experienced Kotlin users though!

> but would it be easier to just always use the fully qualified name? That sounds like it could work. I've no idea how easy that will be, but maybe...

Sorry, we can't pass references over the ffi like that - it has to be strings I think #1974 is what we have open for that.

PR's certainly welcome, and a trivial change like you mention would be a no-brainer IMO. Other changes might stretch the limits of our knowledge so might take more time to...