uniffi-rs icon indicating copy to clipboard operation
uniffi-rs copied to clipboard

Java 8 deprecation is unexpected

Open AugustoFKL opened this issue 1 year ago • 6 comments

From the release 0.26.0, Java 8 seems to be not working for non-android systems (can't tell about those since I'm mostly a enterprise developer).

Java 8 is still one of the three versions with most users according to several studies, and making it not work without notice seems quite weird, so I think it wasn't intended...:?

This happened because the ObjectCleanerHelperJvm.kt file has a UniffiCleaner but the one used by the JavaLangRefCleaner is

 val cleaner = java.lang.ref.Cleaner.create()

Couldn't it be the following instead?

 val cleaner = UniffiCleaner.create()

?

This way it falls back to the internal JNA cleaner if not found, as previously.

AugustoFKL avatar May 25 '24 01:05 AugustoFKL