MGSX

Results 69 comments of MGSX

> Since in Tiled i can have tileset files outside the map. @patton73 actually you can load TMX maps with libGDX which has separated TSX files, in this case tilesets...

Looking to the original issue, it looks like a misuse of the API, i think it would be better to throw an exception when user add non compatible/duplicate buffers instead....

@MikOfClassX do you plan to implement the proper fix? if not, maybe you could close the PR.

> When running the `GL31FrameBufferMultisampleMRTTest` on Windows Desktop I am just seeing a black screen. Is this normal? No, it should looks like this : ![Screenshot 2023-07-21 04:41:21](https://github.com/libgdx/libgdx/assets/8074238/424b7eee-8495-4146-95aa-d19fc2b85559) Maybe on...

> Narrowed the problem down. If I remove `Gdx.gl.glEnable(GL20.GL_DEPTH_TEST);` in render method of test, it works. Or I can keep the depth test, but I must add true to the...

@JamesTKhan i think i addressed all your points (thank you for the review), it seems that you need to review again unblock the merge. @obigu I think it's ready to...

Since all of other Attribute classes expose values as public fields, i think it's preferable to keep them public for consistency. GLES spec is pretty stable now and i don't...

> It's probably okay, so long as everyone's using the constants rather than hardcoding the values. Could be a big problem for users that store key mapping in a file....

any copyright/licence for the source you copied from?

considering this algo is very close to what we already have in intersectRayOrientedBoundsFast, let say we took inspiration from there ;-). FYI, when there is no licence or copyright notice,...