Max Goltzsche

Results 103 comments of Max Goltzsche

Fwiw Integration with beets via Python API directly would tighten the coupling between mopidy and beets (which would potentially introduce maintenance problems down the road, e.g. conflicting python dependency versions)...

I just corrected my earlier assumption that streaming wasn't working because of flask 3 usage: Turns out I didn't use flask 3 actually but still 2. Nevertheless, streaming works with...

I removed my unconfirmed suspicion from the comment now. Maybe flask supports range requests now but there was another problem in my setup/config? I won't investigate that now since I...

The [link you posted](https://github.com/beetbox/beets/blob/bcf180d14dd14604e1d82414fac28d41c275e1c9/beetsplug/web/__init__.py#L307-L340) shows that * the beets web plugin calls the [`flask.send_file` method](https://github.com/pallets/flask/blob/708d62d7172a30c5b0ace1d212c5a3bc2b53b98c/src/flask/helpers.py#L389) * which calls the [`werkzeug.send_file` method](https://github.com/pallets/werkzeug/blob/eafbed0ce2a6bdf60e62de82bf4a8365188ac334/src/werkzeug/utils.py#L318) * which returns the `Accept-Ranges` header [here](https://github.com/pallets/werkzeug/blob/eafbed0ce2a6bdf60e62de82bf4a8365188ac334/src/werkzeug/wrappers/response.py#L703). Thus, looking...

Removing that line within the beets web plugin really fixed the problem. I created a corresponding [beets PR](https://github.com/beetbox/beets/pull/5057) now. I suggest to merge this PR (since it is a valid...

fyi the header processing is part of the `response_class` which is constructed [here](https://github.com/pallets/werkzeug/blob/eafbed0ce2a6bdf60e62de82bf4a8365188ac334/src/werkzeug/utils.py#L487). [A few lines below](https://github.com/pallets/werkzeug/blob/eafbed0ce2a6bdf60e62de82bf4a8365188ac334/src/werkzeug/utils.py#L522), the [`make_conditional` method](https://github.com/pallets/werkzeug/blob/eafbed0ce2a6bdf60e62de82bf4a8365188ac334/src/werkzeug/wrappers/response.py#L709) is called with `accept_ranges=True` when `conditional` is `True` which is...

I just updated the PR, simplifying the workaround, explaining that it is required prior to beets 1.6.1 only and linking to the PR that fixes the beets web plugin bug....

@Kuchiriel, sorry for the late response. I am glad to hear that you like rkt-compose! I must confess it is my first golang application and not written very well. Now...

> Unable to determine content type I ran into the same problem with .m4a and .opus files. I fixed that part of the issue within #14 by explicitly mapping mime...

Thanks for creating the issue @bohdantverdyi! Sure, you could use the alpine-based jnlp-slave image as a base. Though, this repository is not actively maintained, more of an example and there...