Michał Gołębiowski-Owczarek
Michał Gołębiowski-Owczarek
Can you post an online demo of usage of this new property?
@fglueck All I need is a small test case of a dialog working inside of such a container using a version of jQuery UI with your patch. I want to...
@fglueck Thanks, the example looks good. However, we still need test cases (for both when the option is provided and when it's missing). Tests should be added to https://github.com/jquery/jquery-ui/blob/main/tests/unit/draggable/options.js.
If you can add a test case, I'd be in favor of merging this. @fnagel what do you think?
@fglueck It's not just in tests, you can see that in your JSFiddle. If you try to drag the dialog, it immediately moves inside of the `content` element. This suggests...
> @mgol Not sure if we really want to add new features. More code means more bugs and we don't have much resources anyway. Docs and demos are needed too....
Without committing to whether we'll merge this yet (it's a new API and we're trying to be cautious about these now), I'd like to point out that there's still a...
After discussing this with Felix I can say we’re open to merging this feature despite generally trying to avoid adding new features as long as all our concerns are addressed,...
FYI, I think my concerns haven't been addressed so this is still blocked.
> The dialog should be placed at center of what is set in `containment` option? Yes, I think so. In your fiddle, that's still not happening, though. The dialog gets...