Michał Gołębiowski-Owczarek
Michał Gołębiowski-Owczarek
Thanks, Felix! I was also leaning towards treating this as breaking but I wanted a second opinion. Setting the milestone appropriately.
Have a look at the Travis report: https://travis-ci.com/github/jquery/jquery/jobs/462903353 The browser tests there have run on old versions of Chrome/Firefox: Chrome 83 (latest is 87), Firefox 63 (latest is 84!). That's...
@ygj6 Where do you see these errors? Travis shows old versions of Chrome/Firefox as I mentioned above & I don't see errors anywhere else.
@ygj6 I think you can find the reason here: https://github.com/jquery/jquery/blob/a503c691dc06c59acdafef6e54eca2613c6e4032/test/unit/manipulation.js#L2295-L2303 We need `localhost` & `127.0.0.1` to resolve to the same address on which Karma runs and I guess that's not...
> Can we modify the test case, for example, change `typeof response.headers.origin === "string"` to `typeof response.headers.referer === "string"`, and the test will pass. We cannot. The whole point of...
Closing & re-opening the PR to trigger the EasyCLA check...
@ygj6 Hey! It's been a while; are you still interested in finalizing this PR? Your other PR adding GitHub Actions: #4800 has landed, we'll soon remove the Travis setup completely...
@ygj6 Hey, any updates?
@timmywil If a conclusion is to revert the workaround perhaps we could land it in 3.2.1 instead of waiting for 3.3.0? The patch will be simple, the main problem is...
@alex-jitbit Thanks for the info. Is the large number of deferred scripts needed to hit that issue or is a single bug long-loading one enough to hit it?