Martin Geisler

Results 890 comments of Martin Geisler

Hi @c3potheds! Thanks for writing, I very much agree with you that this is confusing and could be made better... In short, the option you're looking for is [`WordSeparator::AsciiSpace`](https://docs.rs/textwrap/latest/textwrap/enum.WordSeparator.html#variant.AsciiSpace). See...

Hey @bonsairobo, I took a quick peek at [your branch](https://github.com/mgeisler/textwrap/compare/master...bonsairobo:textwrap:refill-single-line-rust-comment) and we could add `!` to the list of characters to skip. However, I feel it would be wrong for...

> 1. Re-implement `refill` and `unfill` for Helix while reusing `textwrap`'s `fill`. Not a terrible task, it would probably involve just copy-pasting the current implementation and making some opinionated changes....

Hi @HuyNVuong, thanks for writing! What you see above is just the formatting in the `.po` file. The actual (logical) string stored above starts with ``` The [`while` keyword](https://doc.rust-lang.org/reference/expressions/loop-expr.html#predicate-loops) works...

Great, I think we're on the same page then. Long-term, we'll likely use a translation platform (#1305), and this will hide the formattin of the PO files.

Hi @khoaxuantu, can you rebase this PR and resolve the conflicts? @qu-ngx, can we merge this afterwards?

I looked at the conflict and it was tiny, so I resolved it. I also removed the changes to the `msgid` fields — we want you to _either_ refresh the...

This bumped Vietnamese up a lot in https://google.github.io/comprehensive-rust/translation-report.html :tada: Before there were 480 translated strings, now there will be 547 based on running the report locally.

> @mgeisler I couldn't respond immediately when you mentioned me because of my on-going working hours. No worries at all, I understand that reviewing these PRs is hard and tedious...

By the way, see https://github.com/google/comprehensive-rust/pull/1948#issuecomment-2301415834 for a multi-step procedure to hand-merging out of date `.po` files. I basically treat them as two big maps of `(msgid, msgstr)` entries and put...