Martin Geisler

Results 896 comments of Martin Geisler

@sakex, a new renderer (https://github.com/google/mdbook-i18n-helpers/issues/70) would probably help with this too.

> I don't have approval permissions for this repo but LGTM. Let's fix this, I've invited you now!

Hi @illustager, could you try merging the latest `main` with your branch? You'll have to resolve the conflicts and then push again.

Hi again @illustager, Would you be able to squash the commits on the branch into a single commit and rebase the whole thing on top of `main`? That should resolve...

> I'm so sorry for my long absence (because of heavy schoolwork). I'll finish it this night. No problem at all! Schoolwork should take priority :smile: I was only writing...

I've thought a bit about this for https://github.com/google/comprehensive-rust :-) In general, moving code snippets from the Markdown file to `.rs` files makes it harder to understand the book itself. However,...

> So do I understand you right, that you would advise us against extracting the code examples, because the only benefits would be editor support? I've been working in a...

I'm running into the same issue with Kotlin code: people ask me if it's possible to return a [Kotlin `Result`](https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-result/) instead of a (possibly checked) exception.

> So I think the only path forward is to duplicate (or move) the `uniffi::custom_newtype!(Newtype, u16);` Oh, are you suggesting that I do the macro invocation from the `b` crate...

> > So I think the only path forward is to duplicate (or move) the `uniffi::custom_newtype!(Newtype, u16);` > > Oh, are you suggesting that I do the macro invocation from...