Martin Geisler
Martin Geisler
> I'd suggest looking into [dprint](https://dprint.dev) as a markdown linter. You can run it over md files, or use it like your would prettier. Yeah, that looks like a nice...
> But you shouldn't imply ignoring warnings until you're "done with your implementation" is a good idea, or IMO that ignoring warnings in your source code (as opposed to a...
Hey @cchiw, I see you've assigned this issue to yourself. How do you plan on tackling this?
> 1. Just commenting out the minimal amount of code necessary [Example PR](https://github.com/google/comprehensive-rust/pull/389/files). Note might be a lot for some exercises. This is the style where you comment out the...
Hi @QuineDot, thanks a lot! > You do say "We will look at mutating static data in the chapter on Unsafe Rust", and indeed [have a page on `static mut`.](https://google.github.io/comprehensive-rust/unsafe/mutable-static-variables.html)....
> Probably you can just rephrase this page to "the effective expansion ..." instead of "actual expansion", and "works the same as" instead of "actually becomes". Great idea, thanks! >...
Good point. Let me start by mentioning `Arc` on the `Rc` page (#83).
Hi @QuineDot, Thanks for reading the slides so carefully :-) > [This slide](https://google.github.io/comprehensive-rust/concurrency/threads.html) says that threads are all daemon threads, but this is untrue: > > * For one, you're...
Thanks for all the comments and the thoughts put into them. > * If you mention how it works with `spawn` on Slide A, mention how it works with `scope`...
I created #117 to help a bit with this (I'll leave this issue open since there is more we can do here).