Michael Ganss comments

Results 275 comments of


                                            Michael Ganss

please help, cannot mapped group columns

Unfortunately, there is currently no support for multiple nested properties with the same type, e.g. properties `HomeAddress` and `WorkAddress` of type `Address` in the example above. Also, header columns that...

Update ColumnInfo.cs

I'm hesitant to merge this. Why exactly do you think the default should be changed?

Mapping of nested objects via column index

This should be possible, see here for an example: https://github.com/mganss/ExcelMapper/blob/10a751f40ef0ad48732bf6995556b31b6aab680d/ExcelMapper.Tests/Tests.cs#L2437

add collectionSettersMode none

Good suggestion @kronic Would be great if you could tackle this and create a PR 🙏🏻 The implementation in the example above is probably not thread safe. Perhaps we could...

add collectionSettersMode none

@kronic I think the `none` setter mode is independent of the initialization strategy. Wouldn't it make sense to have just a `none` mode and an additional command line option that...

Feature request: exclude imported types

That's a very good idea. Would you be interested in providing a PR?

Feature request: exclude imported types

I think this could fit somewhere in here: https://github.com/mganss/XmlSchemaClassGenerator/blob/990b09d34d577e4486fa86a85f78db556ec0d0c2/XmlSchemaClassGenerator/Generator.cs#L320-L374

minOccurs="0" with maxOccurs="1" should generate a property and not a collection

@philhunt-ob I agree. This was introduced through the fix for #305 (see commit 7fb535265a36cecd191298b12f646f6e371c1a75). Would you like to take a crack at fixing this? Since the current behavior is here...

XML Serialization problem after migrating from 2.0.792 to 2.0.805 and 2.0.810

Yes, this is the same issue as #378. Although you might not be able to change the upstream XSD, perhaps you can create an XSD as described in https://github.com/mganss/XmlSchemaClassGenerator/issues/378#issuecomment-1536449033 just...

Report LineNumber and file, when schema file could not be read

Good idea. Would be great if you could tackle that and create a PR.