Mark Gibbons

NextJS internalLinkMatcher default matches media URLs which causes issues with query strings

1

### Describe the Bug The internalLinkMatcher default matches media URLs which causes issues with query strings https://github.com/Sitecore/jss/blob/d4bc9e9c9ff9fa4a530950aa23ae854f1da16ea3/packages/sitecore-jss-nextjs/src/components/Link.tsx#L26 ### To Reproduce import { Link as JssLink, } from '@sitecore-jss/sitecore-jss-nextjs'; Set the...

Netlify rewrite issues

2

### Describe the Bug I'm doing a POC on Netlify and have run into a few issues. First, ran into https://github.com/netlify/next-runtime/issues/2284 where the OOTB next.config.js rewrites don't work. Had to...

NextImage loader doesn't correctly set the width and height params

2

### Describe the Bug NextImage loader doesn't correctly set the width and height params on the url depending on the fill value. This results in Sitecore image processor to add...

HMR is not working

7

### Describe the Bug Hot Module Reloading described here https://nextjs.org/docs/app/api-reference/next-cli#development is not working Console logs repeatedly: `WebSocket connection to 'ws://localhost:3000/_next/webpack-hmr' failed: ` Also the whole window refreshes itself every minute...

getMetadata() does not work when using npm workspaces

1

### Describe the Bug Writing component builder to /home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/src/temp/componentBuilder.ts Error: ENOENT: no such file or directory, scandir 'node_modules' at Object.readdirSync (node:fs:1525:3) at getMetadata (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/node_modules/@sitecore-jss/sitecore-jss-dev-tools/dist/cjs/templating/metadata.js:15:31) at generateMetadata (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/scripts/generate-metadata.ts:13:41) at Object. (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/scripts/generate-metadata.ts:10:1)...

Module not found: Can't resolve 'fs' when using @next/bundle-analyzer

1

### Describe the Bug When the @next/bundle-analyzer is installed and configured, building the site gives: ../../node_modules/webpack-bundle-analyzer/lib/analyzer.js Module not found: Can't resolve 'fs' https://nextjs.org/docs/messages/module-not-found Import trace for requested module: ../../node_modules/webpack-bundle-analyzer/lib/viewer.js ../../node_modules/webpack-bundle-analyzer/lib/index.js...

Link component change in href rendering behaviour without applicable unit test

5

### Describe the Bug The change here https://github.com/Sitecore/jss/commit/b4309e8c7f8464c642e9dbe478b909f73df89ab9#diff-cd0f8f166dc72a9504e6cf7b0dfaaf409561f62d651b115c3e8185151162c7e1R36 in JSS 21.1.0 is a breaking change in that it needs a metadata property otherwise it will not render the link. There...