jss icon indicating copy to clipboard operation
jss copied to clipboard

Link component change in href rendering behaviour without applicable unit test

Open mg-aceik opened this issue 6 months ago • 5 comments

Describe the Bug

The change here https://github.com/Sitecore/jss/commit/b4309e8c7f8464c642e9dbe478b909f73df89ab9#diff-cd0f8f166dc72a9504e6cf7b0dfaaf409561f62d651b115c3e8185151162c7e1R36 in JSS 21.1.0 is a breaking change in that it needs a metadata property otherwise it will not render the link.

There isn't actually any unit test that is asserting this - e.g. you could have a field with a value and href, but if no metadata is set then it still returns null. I'm not sure if that was intentional or not and so I think a unit test should be added to assert that it was intentional.

To Reproduce

N/A

Expected Behavior

N/A

Possible Fix

N/A

Provide environment information

  • Sitecore Version: XM Cloud
  • JSS Version: 22.1.0

mg-aceik avatar Aug 28 '24 00:08 mg-aceik