Mason Freed

Results 546 comments of Mason Freed

> Ok, I got my branch back up to date, removed the serialization stuff, and renamed "include shadow roots state" to "allow declarative shadow DOM flag". I believe I fixed...

> > Ok, I got my branch back up to date, removed the serialization stuff, and renamed "include shadow roots state" to "allow declarative shadow DOM flag". I believe I...

> It's literally a HTML parse error, because your closing tag is missing a / Well that is just exceedingly embarrassing. Thanks. Will fix. Ugh.

> > It's literally a HTML parse error, because your closing tag is missing a / > > Well that is just exceedingly embarrassing. Thanks. Will fix. Ugh. I guess...

> There's still a missing `` error, but I'll look at that tomorrow. That's now fixed too. This should be good to go.

> Still some validation errors on the build output: Ahh - I wasn't running the conformance checker. Seems like that should be part of build.sh maybe? The error has been...

> > Seems like that should be part of build.sh maybe? > > It adds about 5 minutes to the build process, so we omit it... Hmm, ok understandable then....

> Thanks for your work on this @mfreed7. I would say that modulo some details WebKit can be considered supportive and I don't think Mozilla is objecting (@smaug----?) so it...

> Sure, the simplest approach is to hook into where template element's start tag is parsed, and instead of inserting the template element to its parent, create a template element...

> Thanks! Does this approach sound reasonable to other folks? If so, I can try adding it to this PR, and prototyping it in Chromium. Also, @rniwa did you happen...