Mason Freed
Mason Freed
> > Since hidePopUp() may wait for animations to finish, should it return a promise? > > @mfreed7 what do you think? I see that currently we have a pseudo...
Ok, I believe this PR is ready for review. This is my first time with a PR of this size against HTML so please let me know what I need...
Any comments on this PR? No rush, just bumping it in case people would like to take a look.
> It seems this doesn't properly introduce all the new `template` attributes and adds them to the various indexes (top of the `source` document has instructions). I guess some special...
Just checking in on this PR. Is there anything missing, other than multi-implementer interest?
This PR has been updated to include the "opt-in" mechanics described in [#912](https://github.com/whatwg/dom/issues/912). The changes I made here roughly match the current implementation of Chromium, so I'm hoping they're functional....
> I'm also missing a description of all the new `template` element attributes (and their addition to various indexes). Sorry - can you clarify what you mean here? Do you...
> As for documentation, there is some advice in the README as well as pointers to various other documents, but I don't think we have anything directly covering wattsi (HTML)...
@rniwa thanks for the updated review! I'm glad you're interested in the feature. I made some replies, and I'll make a few changes to the PR early next week, including...
> @rniwa thanks for the updated review! I'm glad you're interested in the feature. I made some replies, and I'll make a few changes to the PR early next week,...