Mason Freed
Mason Freed
> > Thanks! Does this approach sound reasonable to other folks? If so, I can try adding it to this PR, and prototyping it in Chromium. > > Also, @rniwa...
> @rniwa can you review the new parser bits? It seems many of the old comments are still outstanding so maybe just look at the parser aspects for now. Yep,...
This issue is quite related to https://github.com/openui/open-ui/issues/415, and in particular, https://github.com/openui/open-ui/issues/415#issuecomment-1261460981. This entire issue would be moot if `blur()` were **not** a light dismiss trigger, correct? The keyboard user would...
Since we [just resolved](https://github.com/openui/open-ui/issues/415#issuecomment-1285995113) to remove `blur` as a light dismiss trigger for pop-ups, at least by default, that should solve this issue. I'll close it, but feel free to...
The counterpoint, I guess, might be that if later there are other non-pop-up things that show and hide, it'd be nice to re-use an easy set of events like `show`...
> > other non-pop-up things that show and hide > > Well, I think ``s show and hide pretty frequently already, when you e.g. change them from `display: none` to...
I filed an issue with WHATWG/dom, since this is now a more general feature. https://github.com/whatwg/html/issues/8386
Thanks for the pointer to https://github.com/w3c/csswg-drafts/issues/4410#issuecomment-783022435, I had seen that but hadn't read it in detail. I'm in favor of trying to do what you lay out in that comment...
> We still have that optimization. We just made it not run when it's observable. @rniwa can you add some detail about how you do that, ideally with a link...
> @mfreed7 https://github.com/WebKit/WebKit/blob/14c0a0df4180c23444c0c87502e96020065d0585/Source/WebCore/editing/markup.cpp#L1372-L1377. Thanks. So no mutation observers, mutation event listeners, and no references to the text node. The last part is interesting, since a) it's hard to do in...