Mattias Fält
Mattias Fält
> I must say I am taken aback by the hostile reactions I am getting here, nitpicking at details while there is a glaring hole in the functionality of `ControlSystems`....
I agree that we should fix this. It should be fairly straight forward if we use `one(T)` and `zero(T)` to compute the promotion type instead. However, the following in `promotion.jl`...
I assume we would have a similar problem for the corresponding `HeteroStateSpace`, but we seem to avoid defining promote rules with numbers by calling the constructors in those cases, so...
I don't think we should do any rounding i of the elements internally. But it could be a reasonable option to print the systems in a prettier way. I don't...
> In terms of implementation, I came over something possibly relevant in the Polynomials.jl documentation (https://github.com/JuliaMath/Polynomials.jl): > > "`chop` chops off any small leading values that may arise due to...
I haven't thought about this too much so please correct me where I'm wrong, I have probably missed something with L/H Are they not both valid norms and operator norms?...
I think that we should follow the interface defined here: https://docs.julialang.org/en/v1/stdlib/LinearAlgebra/#LinearAlgebra.norm https://docs.julialang.org/en/v1/stdlib/LinearAlgebra/#LinearAlgebra.opnorm wherever it makes sense. Edit: It doesn't stop us from also giving useful names to some of the...
I agree with what @baggepinnen wrote, I would like this to be an alternative to the MATLAB Control System Toolbox as far as that is possible to achieve. I think...
Thanks for the great work, it looks a lot better. Unfortunately, we just pulled a set of major changes into the package (this beast https://github.com/JuliaControl/ControlSystems.jl/pull/118) so I'll have to take...
We should figure out how this can be used in some convenient way for `lsim` or similar.