Mattias Fält

Better tests for margin

1

This bug was fixed but we have no tests that cover it. https://github.com/JuliaControl/ControlSystems.jl/pull/524

WIP: Adaptive sampling

9

Implements functionality for adaptive sampling of functions based on the expected use. For example sampling of frequency response, knowing that it will be used in a loglog plot for magnitude...

fixed promotion for delay systems

2

Minor fix where promotion from TransferFunction didn't work correctly.

Doctest, and therefore tests fail on PkgEval for the upcoming Julia 1.6. It is a bit annoying that we keep getting errors from formatting of the printing, but it was...

pidplots still used old plots syntax, and is apparently mising tests

1

Our docs have apparently not been properly compiled (and updated) for a while since they were running the `pidplots` function which uses the `subplot` command. Could you update this function...

We can use this issue to keep track of known bugs, issues and the progress we are making after pulling the major autodiff branch Bugs - [x] `pole` for mimo...

We seem to use `to_matrix` only in one location https://github.com/JuliaControl/ControlSystems.jl/blob/9e5a846d1ac7928a816e78d6b55ce0d4e634996e/src/types/StateSpace.jl#L53 Where we for example already fail if `D=LinearAlgebra.I`. Maybe we should actually have a version that explicitly takes in dimensions...

JuliaControl Bot

1

I thought we should have an issue discussing how we want the @JuliaControlBot to work. Currently * it compares a PR to the reference images in https://github.com/JuliaControl/ControlExamplePlots.jl and replies with...

Type instability _bounds_and_features

1

We have some horribly type unstable code in `_bounds_and_features`

Since changing to continuous simulations we lose accuracy in lsim compared to the previous zoh method when the input is already zoh. (see https://github.com/JuliaControl/ControlSystems.jl/pull/118#discussion_r167433616) Step was, for example, exact almost...