Raul Metsma

Results 128 comments of Raul Metsma

git clone --recursive handles this well? The problem arises when you want make changes in submodule then it is nearly impossible to test it out in own fork. I agree...

I have some Fedora changes already in #633 can I update my PR with your changes or do I rebase it on it?

Can you please rebase to latest master

Thats why there is code reference in wiki when code changes you can still find relevant parts. How is the fetchcontent better current download solution?

My concern is that it should not be offline. The config files should be updated regularly. Least once on every release. https://src.fedoraproject.org/rpms/qdigidoc/blob/rawhide/f/config.json As example `20230504110015Z` over year old config is...

> On the Fedora packaging side unfortunately all sources must be vetted for licensing issues and uploaded manually I am actually not sure how the config and TSL-s are licensed....

> For example, config.json seems rather meaningless to have downloaded. It could be included in the github repo and have the server redirect to the raw file url. What do...

> Sorry, I meant `config.qrc` It is already in repo https://github.com/open-eid/qt-common/blob/master/config.qrc

I think updating files with DigiDoc release is good enough. `config.json`, `config.rsa`, `eu-lotl.xml`, `EE.xml`. All the files are also updated regularly on runtime.

> @pxrb for a better code impagination, use ``` code ``` > > 4.5.1 works because yesterday I managed to [build it](https://koji.fedoraproject.org/koji/buildinfo?buildID=2477550) https://src.fedoraproject.org/rpms/qdigidoc/tree/rawhide Also make sure you have `1251.patch' Please...