Raul Metsma comments

Results 128 comments of


                                            Raul Metsma

Support of OpenSSL providers for digest calculation

xmlsec1 is used to verify data references and signaturevalue https://github.com/open-eid/libdigidocpp/blob/master/src/XMLDocument.h#L415-L446 OCSP and timestamps use Digest object

Support of OpenSSL providers for digest calculation

Seems like xmlsec1 uses fetch method https://github.com/lsh123/xmlsec/blob/master/src/openssl/digests.c#L313C67-L313C77

Allow disabling of certificate check during signature verification

Currently no.

initCallBack called with no error during digidoc::initialize if TSL downloading failed

https://github.com/open-eid/libdigidocpp/blob/master/src/crypto/TSL.cpp#L197-L237 Seems like TSL parsing handles all exceptions

Tests crash when run without a network connection

This is known issue. The network is required currently to run unittests.

Tests crash when run without a network connection

I majority of test require network. There is built in OCSP server in OpenSSL that can be used. Need to figure out how to implement TimeStamp server with OpenSSL.

option '--skip-chrome' doesn't allow an argument

What version opensc is installed? It should be fixed in RIA repository.

option '--skip-chrome' doesn't allow an argument

I wonder why it does not install this version https://installer.id.ee/media/ubuntu/pool/main/o/opensc/. It should update apt cache and force install/upgrade opensc https://github.com/open-eid/linux-installer/blob/master/install-open-eid.sh#L93-L94