Inada Naoki

Results 344 comments of Inada Naoki

ping? @julienschmidt

golang/go#47953 was rejected and closed. Now I proposed https://github.com/golang/go/issues/60370

I won't add it in this driver. Please copy&paste the `sql.Null[T]` from Go 1.22 into your application until you can use Go 1.22. ("A little copying is better than a...

@dolmen We don't require rebase. * We use "Squash and merge" commit so no need for clean history in pull request branch. * rebase breaks PR sometime. python/cpython is suffered...

> * `disabled`: no compression, default value > * `preferred`: use zlib compression if offered by the server > * `required`: use zlib compression, error if not offered by the...

Maybe. But not in 1.9. This PR is still inefficient. I will need more improvement.

I realized we need massive rewrite. So nitpick comments are not helpful to me.

Yes, it violates database/sql convention. But this violation is necessary to support uint64. So we can not fix it until database/sql supports uint64 natively.

There is perfect document. https://cs.opensource.google/go/go/+/master:src/database/sql/convert.go;l=219-480 https://github.com/go-sql-driver/mysql/blob/d7ddb8b9e324830b1ede89c5fea090c824497c51/packets.go#L769-L856 https://github.com/go-sql-driver/mysql/blob/d7ddb8b9e324830b1ede89c5fea090c824497c51/packets.go#L1230-L1403 It must be readable than my English.

Current master branch contains number of new features and changes. If there are important fix, I will create 1.7 branch and cherrypick them. But "9 months" is unclear to me....