mysql icon indicating copy to clipboard operation
mysql copied to clipboard

Cut a new v1.7.2 release

Open derekperkins opened this issue 7 months ago • 6 comments

There are still several issues in the v1.8 milestone, so that may still be a ways out. Could we get a v1.7.2 release containing fixes from the last 9 months?

derekperkins avatar Jan 05 '24 14:01 derekperkins

@methane / @shogo82148 I don't know the current state of the project, but the request sounds reasonable. And the milestone planning looks quite stale. Do you see any blockers concerning a release?

arnehormann avatar Jan 26 '24 20:01 arnehormann

Current master branch contains number of new features and changes. If there are important fix, I will create 1.7 branch and cherrypick them. But "9 months" is unclear to me. What bugfix is important for you?

I want to merge compression before 1.8. But it is possible to postpone some changes to 1.9 and release 1.8 before Go 1.22.

methane avatar Jan 27 '24 00:01 methane

I'm personally interested in this fix https://github.com/go-sql-driver/mysql/pull/1432, which will hopefully then get picked up by grafana.

As of now, there are 48 commits since 1.7.1 last April. I wasn't sure what triggered a new release, since there hasn't been a consistent cadence. https://github.com/go-sql-driver/mysql/compare/v1.7.1...master

derekperkins avatar Jan 27 '24 00:01 derekperkins

#1432 looks not a bugfix, but a new feature with small backward incompatibility. So focusing 1.8 would be better.

methane avatar Jan 27 '24 00:01 methane

https://github.com/go-sql-driver/mysql/pull/1473 is an important bug fix for us that we'd be grateful to have in a v1.7.2 release.

owbone avatar Feb 05 '24 11:02 owbone

and also drop support for 5.7 as its reached end of life

ravarage avatar Feb 19 '24 10:02 ravarage

@methane Is this the PR you're hoping to land before v1.8?

  • https://github.com/go-sql-driver/mysql/pull/1487

derekperkins avatar Feb 25 '24 22:02 derekperkins

@derekperkins Yes, I was. But now I think it is better to make 1.8 before merging it because it is large PR. We can merge it right after we released 1.8. Users can try compression by using @master.

methane avatar Feb 26 '24 09:02 methane

Gotcha - do you know what the timeline might be for a 1.8 release? Eagerly awaiting it as well, esp. with the ed25519 support

ldanielw1 avatar Mar 04 '24 22:03 ldanielw1

No plan. I want to make it as fast as possible. But our review process make us slow.

methane avatar Mar 06 '24 06:03 methane

and also drop support for 5.7 as its reached end of life

@ravarage like in horror story there might be some applications that still might be using mysql 5.7

sujit-baniya avatar Mar 08 '24 06:03 sujit-baniya

I don't plan to drop MySQL 5.7 support this time. Maybe, 1.9 may drop it. But "drop support" doesn't mean "don't work". It just mean we won't maintain CI for MySQL 5.7.

methane avatar Mar 08 '24 07:03 methane

https://github.com/go-sql-driver/mysql/releases/tag/v1.8.0

methane avatar Mar 09 '24 07:03 methane

Thanks @methane!

derekperkins avatar Mar 09 '24 08:03 derekperkins