Inada Naoki

Results 344 comments of Inada Naoki

@shogo82148 How do you think this new API?

Although I like this feature, I want to wait adding more fields to Config object. Please wait for the discussion in https://github.com/go-sql-driver/mysql/discussions/1548

> Some connections were hit by #1393 and #1394, which caused a large number of failed requests, but `CheckConnLiveness` ensured that the majority of the connections were discarded and replaced...

> I agree that it could mask an underlying network problems, but only for idle connections. Unlealthy network kills not only idle connections, but also connections waiting results/sending query. So...

> This is why I say we're _not_ special. Other users will not be following the recommended timeouts, because they haven't needed to (thanks to `CheckConnLiveness`) - a recommendation is...

> I wonder if that situation could be improved by using [`unix.Poll()`](https://pkg.go.dev/golang.org/x/sys/unix#Poll) instead of `syscall.Read()`? I tried to implement it. https://github.com/go-sql-driver/mysql/pull/1456 If it works fine, no need to chose one...

> Reading #934, can I ask: what command were you using to detect variables escaping to the heap? What is its output today? I don't remember. Google "golang compiler option...

Most simple and quick way is just user pass the location to sqlc. User knows dsn or mysql.Config so that user knows the correct loc. For future, my idea is:...

I find my old idea: https://github.com/go-sql-driver/mysql/pull/1060#issuecomment-585574043