Yun Peng

Results 201 comments of Yun Peng

@sgowroji No, I meant those two have the same root cause, but should be fixed in both projects. That means a similar change should be made in rules_webtesting (or in...

Those are the files are originally in bazel-genfiles but moved to bazel-bin folder with this flag. ``` pcloudy@pcloudy0-w MSYS ~/workspace/protobuf $ tree bazel-genfiles bazel-genfiles └── src └── google └── protobuf...

@acozzette Sorry for the late reply here, I think you should use the C++ runfiles library provided by Bazel to look up for test data files: See the usage here:...

BTW, why didn't it see `src/google/protobuf` inside `bazel-genfiles` before?

@acozzette Thank you so much for the fix! I verified manually, it did fix this issue!

@compnerd Sorry, I currently don't have capacity to look into this. Is it possible to tweak your commands in the presubmit.yml to debug and workaround this? I believe the Windows...

@compnerd I think you are correct, the buildkite agent doesn't run with admin previleges, see how the user is created: https://github.com/bazelbuild/continuous-integration/blob/1f2d17f7ecd363813c7027b4061f5245f7bf1b58/buildkite/setup-windows.ps1#L279-L288 However, I'm not sure we can give the buildlkite...

@fweikert Do you have any idea whether we can give the buildkite agent user admin right? We should be able to do it by adding ``` Add-LocalGroupMember -Group "Administrators" -Member...