rules_webtesting icon indicating copy to clipboard operation
rules_webtesting copied to clipboard

rules_webtesting is failing with Bazel@HEAD in CI

Open sgowroji opened this issue 1 year ago • 7 comments

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3165#01895229-4fb7-4ff9-9027-04b0cb372a34

Platform : Ubuntu, MacOS, Windows Logs :

return java_common.pack_sources(
	File "/virtual_builtins_bzl/common/java/java_common.bzl", line 150, column 68, in _pack_sources
Error in _check_java_toolchain_is_declared_on_rule: Rule 'scala_library_for_plugin_bootstrapping' in '/private/var/tmp/_bazel_buildkite/babcd828cef764fd2f88fc3cf799c018/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD:6:39' must declare '@bazel_tools//tools/jdk:toolchain_type' toolchain in order to use java_common.
(04:24:42) ERROR: /private/var/tmp/_bazel_buildkite/babcd828cef764fd2f88fc3cf799c018/external/io_bazel_rules_scala/third_party/dependency_analyzer/src/main/BUILD:6:39: Analysis of target '@io_bazel_rules_scala//third_party/dependency_analyzer/src/main:scala_version' failed
(04:24:42) ERROR: Analysis of target '//scalatests/com/google/testing/web:WebTestTest_chrome-win10-connect' failed; build aborted: Analysis

Steps:

git clone https://github.com/bazelbuild/rules_webtesting.git 
git reset 9f39b9dd292c763cef44cc63719e399373b17631 --hard
export USE_BAZEL_VERSION=53914865fc26850a1f282a83f3846c6103af217e
bazel build //...

CC Greenteam @SalmaSamy

sgowroji avatar Jul 14 '23 06:07 sgowroji

Hi @DrMarcII , Can you please have a look on this issue. Thanks!

sgowroji avatar Jul 19 '23 05:07 sgowroji

Hello @DrMarcII or the rules_webtesting team, in case the failures persist without resolution for an extended period, we may need to transition this to the disabled pipeline. It would be greatly appreciated if you could respond and provide us with an update. Thank you!

sgowroji avatar Jul 25 '23 05:07 sgowroji

I am no longer working on web testing in any form. I have messaged someone who might care about this to see what they want to do.

On Mon, Jul 24, 2023 at 10:43 PM Gowroji Sunil @.***> wrote:

Hello @DrMarcII https://github.com/DrMarcII or the rules_webtesting team, in case the failures persist without resolution for an extended period, we may need to transition this to the disabled pipeline. It would be greatly appreciated if you could respond and provide us with an update. Thank you!

— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/rules_webtesting/issues/458#issuecomment-1649157929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7LJGORU4BHSLVT2LRTZ6TXR5MGHANCNFSM6AAAAAA2J4DZFE . You are receiving this because you were mentioned.Message ID: @.***>

DrMarcII avatar Jul 26 '23 20:07 DrMarcII

What's the implication of transitioning to the disabled pipeline? Do you have any idea what the suggested fix is for this issue or what change might be causing it?

mtrea avatar Jul 27 '23 20:07 mtrea

CC @meteorcloudy

sgowroji avatar Jul 28 '23 05:07 sgowroji

What's the implication of transitioning to the disabled pipeline?

@sgowroji meant the downstream pipeline for Bazel@HEAD, check the doc and policy here: https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md

I believe this is the same root cause as https://github.com/bazelbuild/rules_jvm_external/issues/931, but from the error message, it seems this should be fixed in rules_scala first.

meteorcloudy avatar Jul 28 '23 10:07 meteorcloudy

@sgowroji No, I meant those two have the same root cause, but should be fixed in both projects. That means a similar change should be made in rules_webtesting (or in rules_scala then update rules_scala in rules_webtesting).

meteorcloudy avatar Jul 28 '23 10:07 meteorcloudy