Simeon H.K. Fitch
Simeon H.K. Fitch
Ditto on this one. In dark theme at least, the emoji actually make the status harder to read.
Here are my thoughts on the points you brought up, but I must admit to knowing very little of the `cargo` internals and the various link stages it works with,...
Another option to keep it simple (until proven to be insufficient in the wild): | Target Kind | Flag | Note | | ----------- | ----------------------------------------- | --------------- | |...
@thomas001 Is `OGR_G_MakeValid` just one of many calls you're wanting to make, or would the more convenient approach be to add something like `Geometry::make_valid` instead? In the future, I wonder...
> Can you compile the code it's testing? I'm not familiar enough with what's going on here to know what you mean... I'm guessing you mean something other than `cargo...
@lnicola : Transcript: ``` ❯ git rev-parse --short HEAD 24280ad ❯ cp tests/compile-tests/*.rs examples ❯ cargo check --example 01-features-aliasing-errors ... error[E0502]: cannot borrow `layer` as immutable because it is also...
> Are your saying that cargo test vector -- test_features_aliasing_compile_fail actually fails reliably? Yep... Test never passes on my local machine. ~~I'll do a manual diff next.~~ Edit: when run...
This is mostly just annoying. To get around it I just run with `TRYBUILD=overwrite` and move on. Not sure I understand what is being achieved with this test anyway.
Upgraded `trybuild ` to `1.0.71`. Ran `cargo clean && cargo test vector -- test_features_aliasing_compile_fail` Same error, different rendering: test tests/compile-tests/01-features-aliasing-errors.rs ... error Expected test case to fail to compile, but...
> This is very far-fetched Hah! I was almost convinced you were right off the bat!... however... 😞 ❯ cargo clean && cargo test ... test tests/compile-tests/01-features-aliasing-errors.rs ... error Expected...