Cyril Hrubis

Results 134 comments of Cyril Hrubis

Can you send a proper [signed](https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=signed%20off#sign-your-work-the-developer-s-certificate-of-origin) patch please?

Sounds like a good idea. I guess that we can even run the checkpatch.pl (from a kernel git repo) to check the incoming patches as well. I will have a...

It would be nice to have this as a pre-commit hook, unlike compilation this could be fast and efficient.

You basically need to write down your custom runtest file, see runtest/syscalls for how it should look like with tests that works on readonly FS. Then you can pass that...

Hmm so this means that in certain cases we have to keep more than one CPU online. I guess that the test should be changed so that it works fine...

The minimal kernel version the current LTP head supports is 3.10 see doc/supported-kernel-libc-versions.txt so there is no point in keeping tests for interface removed in 3.5, we should remove these...

I do not get how the test can run multiple times at all, the `main()` function is called exactly once so there is no need to reset the value at...

Looks some failures in the cgroup tests, but can't even try to figure out the problem without proper information, that is OS it runs on, LTP version, which exact test...

You haven't provided any information about the system where these tests were executed on, the package and version of the file binary, nor the LTP version. It's impossible to figure...

Looking at the patch https://github.com/linux-test-project/ltp/commit/813457d01c2b3db6e1f5f1fa4291b932e132bb30 it seems to be wrong though. The TCGETA for termio is called TCGETS for termios, we need separate lines with different ioctl cmds for different...